Re: patch-review

[David Nečas (Yeti) <yeti physics muni cz>]

On Mon, Aug 13, 2007 at 11:25:01PM +0300, Stefan Kost wrote:
> 
> Regarding http://bugzilla.gnome.org/show_bug.cgi?id=338068#c4
> * we could stop disting .types file only if projects requite gtkdoc-1.8 and use
> --rebuild-types in their SCAN_OPTIONS. Any idea how to improve the makefile
> logic to figure out?

I would just

  echo x$(SCAN_OPTIONS) | grep '^x.*--rebuild-types'

in dist and clean hooks to check whether the option is
present.  The same for sections.  The `x' is there to avoid
passing something that starts with `-' to echo and grep,
they could react unpredictably -- cleaner suggestions
welcome.

> * I agree with not disting the xml files. patches welcome

They will flow...

Beside content XMLs, the only files you need to distribute
are
- the driver document
- overrides
- sections (unless --rebuild-sections is used)
- types (unless --rebuild-types is used)

> * Getting rid of "@-chmod -R u+w $(srcdir)". Is this
> http://bugzilla.gnome.org/show_bug.cgi?id=460753 ?

This is just a small (although necessary) part of it.
The main bug is the old here:

  http://bugzilla.gnome.org/show_bug.cgi?id=127049

and the main patch is the addition of --master-dir=DIR
option to all relevant tools.  In the modern makefile, they
will get --master-dir=$(srcdir) and they will look for files
in the build directory or (failing that) in the master
directory.

Old-style makefiles will behave as before, which means VPATH
builds not really working.

> Regarding http://bugzilla.gnome.org/show_bug.cgi?id=338068#c6
> * If you have an idea how, lets fix it.

This will be fixed automatically when we start building in
builddir.  All files are created in builddir then (well,
with a few exceptions, for instance the initial driver
document will be created in the master directory -- if I got
it right the tools are smart enough to know whether you want
for instance the section file in builddir or srcdir, anyway,
I do not expect people to use VPATH builds for bootstrapping).

Note none of the bugs contain gtk-doc.make patches,
I prefer to first add the capability to the tools
(~mechanism), then, possibly, change the default makefile
(~policy).

Yeti

--
http://gwyddion.net/