Re: patch-review

[Stefan Kost <ensonic hora-obscura de>]

Hi,

David Nečas (Yeti) wrote:
> On Sat, Aug 11, 2007 at 12:41:14PM +0300, Stefan Kost wrote:
>> I belive a have a fix for the tmpl build (3 lines). I'll commit it in a minute.
>> I would also like to commit the gtkdoc.modern.make, so that we can work on it.
>> Is that okay with you?
> 
> Ok.
> 
> Please also apply simple fixes such as
> http://bugzilla.gnome.org/show_bug.cgi?id=459225

done.

> 
>> What do you think about the gtkdocize issues?
>> * should I add a --force option?
> 
> Can't judge, I'm not a big fan of these (I even use an ugly
> hack in my autogen to steal files from gettextize without
> actually running it...).
> 
>> * what about the flavour naming?
> 
> According to the main change it brings.
> 
> You need a new flavour only if you substantially change the
> style and mode of operation.  If the result cannot be
> described with a catchy phrase, it does not worth the
> work...  So I would call the new one `notmpl' or something
> like that (I would prefer if it also included bulding in
> builddir, but that's something notmpl makes possible so the
> name still fits).

Also done. Will commit after a bit of testing. I would also like to bump the
version. What about bumping the version immediately after a release. So I would
bump it to 1.9 now and after its released to 1.10. Okay?

Stefan