Re: MSVC compilation problem in git master

[Emmanuele Bassi <ebassi gmail com>]

On 25 August 2017 at 10:13, John Emmas <john creativepost co uk> wrote:
> Please point me to the right place (if this isn't the correct mailing
> list...)
>
> I've just updated gdk-pixbuf from git master.  'gdk-pixbuf.c' used to
> contain this #include at line 38:-
>
>       #include "gdk-pixbuf-marshal.c"
>
> However... in commit  #591f959adb  that got changed to this:-
>
>       #include "gdk-pixbuf-marshal.h"
>
> and the explanation given was "Do not include the source, otherwise we're
> going to compile symbols twice".  Unfortunately though, when building with
> MSVC, I now get unresolved symbols (due to the fact that
> gdk-pixbuf-marshal.c isn't getting compiled any more).  I'm probably missing
> something obvious but how does it get compiled now?  I can't see it in any
> of the Visual C++ projects...

It gets compiled alongside the rest of the sources — see
`libgdk_pixbuf_2_0_la_SOURCES` in the Autotools build.

The Visual Studio project files are not up to date, and since we're
switching the build to Meson, I don't think they'll stay in tree much
longer.

Ciao,
 Emmanuele.

-- 
https://www.bassi.io
[@] ebassi [@gmail.com]