Re: [PATCH] icon-theme: fix leak in insert_theme()

On 01/12/12 01:42, Alex Chiang wrote:
> We allocate path with g_build_filename() but never free it.

I don't think this patch is correct. Ownership of @path is given to
@dir_mtime at line 1109 (in git master as of 97c235405d9), so freeing it
as in your patch causes a use-after-free in rescan_themes() and
theme_subdir_load(), and eventually a double-free in free_dir_mtime().

If you disagree with my reasoning, please open a bug on where this can be discussed. You're welcome to quote
this email there.


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]