Re: GFilterInputStream: why "close-base-stream" property marked as "construct-only"?



On Fri, 2011-04-29 at 15:13 +0300, Andrew W. Nosenko wrote:
> GFilterInputStream documentation (and implementation) clearly states
> that "close-base-stream" property is "construct-only".  And
> g_object_set() forbids to change it indeed.
> 
> But, from another hand, existence of
> g_filter_input_stream_set_close_base_stream() and code in
>     gio/tests/buffered-input-stream.c
> and
>     gio/gdbusauth.c
> clearly shows that this flag really intended to be changed at
> run-time, after construction.
> 
> Is there a reason to keep this property to be contruct-only,
> preventing g_object_set() from changing it?
> 

This is just a cut and paste bug in the property definition. The very
existance of (non-property-using) methods to change this makes it
obvious that its runtime changable. I'll fix this.



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]