[patch] constify g_simple_async_result_set_from_error



In PackageKit, I have to explicitly cast in my finish function:

static void
pk_package_sack_merge_state_finish (PkPackageSackState *state, const
GError *error)
{
...
		g_simple_async_result_set_from_error (state->res, (GError*) error);
...
}

The finish function is passed a const GError (as the error can't be
freed), hence the cast is required for the compiler not to warn.

Of course, the correct thing to do would be to trivially fix gio, and
a patch is attached that does exactly that. Okay to commit?

Richard.

Attachment: 0001-Make-the-error-const-for-g_simple_async_result_set_f.patch
Description: application/force-download



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]