Re: gdk_window_set_skip_taskbar_hint issue

[Cody Russell <bratsche gnome org>]

I can test this patch sometime this week, or this weekend.  In
particular, we need to verify that this doesn't break the transient
window stuff.

On Wed, 2009-03-04 at 12:49 -0300, Rodrigo Miguel wrote:
> > Not unless you have a patch to offer?
> 
> Well that was working fine until 2.12.x version when somone introduced
> the code below:
> 
>   // ### TODO: Need to figure out what to do here.
>   return;
> 
> and a #if 0 as well
> 
> ;)
> Rodrigo
> 
> 
> 
> void
> gdk_window_set_skip_taskbar_hint (GdkWindow *window,
> 				  gboolean   skips_taskbar)
> {
>   static GdkWindow *owner = NULL;
>   GdkWindowAttr wa;
> 
>   g_return_if_fail (GDK_IS_WINDOW (window));
> 
>   GDK_NOTE (MISC, g_print ("gdk_window_set_skip_taskbar_hint: %p: %s,
> doing nothing\n",
> 			   GDK_WINDOW_HWND (window),
> 			   skips_taskbar ? "YES" : "NO"));
> 
>   // ### TODO: Need to figure out what to do here.
>   return;
> 
>   if (skips_taskbar)
>     {
>       if (owner == NULL)
> 	{
> 	  wa.window_type = GDK_WINDOW_TEMP;
> 	  wa.wclass = GDK_INPUT_OUTPUT;
> 	  wa.width = wa.height = 1;
> 	  wa.event_mask = 0;
> 	  owner = gdk_window_new_internal (NULL, &wa, 0, TRUE);
> 	}
> 
>       SetWindowLongPtr (GDK_WINDOW_HWND (window), GWLP_HWNDPARENT,
> (LONG_PTR) GDK_WINDOW_HWND (owner));
> 
> #if 0 /* Should we also turn off the minimize and maximize buttons? */
>       SetWindowLong (GDK_WINDOW_HWND (window), GWL_STYLE,
> 		     GetWindowLong (GDK_WINDOW_HWND (window), GWL_STYLE) &
> ~(WS_MINIMIZEBOX|WS_MAXIMIZEBOX|WS_SYSMENU));
>       SetWindowPos (GDK_WINDOW_HWND (window), NULL,
> 		    0, 0, 0, 0,
> 		    SWP_FRAMECHANGED | SWP_NOACTIVATE | SWP_NOMOVE |
> 		    SWP_NOREPOSITION | SWP_NOSIZE | SWP_NOZORDER);
> #endif
>     }
>   else
>     {
>       SetWindowLongPtr (GDK_WINDOW_HWND (window), GWLP_HWNDPARENT, 0);
>     }
> }
> _______________________________________________
> gtk-devel-list mailing list
> gtk-devel-list gnome org
> http://mail.gnome.org/mailman/listinfo/gtk-devel-list