Re: g_format_file_size_for_display()

[David Zeuthen <david fubar dk>]

On Tue, 2007-12-18 at 14:50 -0600, Federico Mena Quintero wrote:
> Should this be called generically g_format_size_for_display()?  You
> could use it for more than file sizes (free RAM in gnome-system-monitor,
> etc.).

It's here btw

http://svn.gnome.org/viewvc/glib/trunk/glib/gfileutils.c?revision=6076&view=markup

char *g_format_file_size_for_display (goffset size);

Ideally this one needs to take another parameter indicating whether you
want 1kb = 1000 bytes or 1kb = 1024 bytes. 

The reason is that we want to generate nice display names in the volume
monitor; for ordinary media you want 1000 (to match the label on the
media); for optical discs you normally want 1024. gnome-vfs has this
terrible bug where it uses 1024 so you get the label "61.2 MB" media
even when the media itself says 64MB. This is kinda like punching the
user right in the face. It's not a mistake we should make for the new
shiny gvfs stuff.

      David