Re: #80127 Rubberbanding issues

On Tue, May 16, 2006 at 05:37:06PM +0100, Ross Burton wrote:
> On Tue, 2006-05-16 at 12:25 -0400, Matthias Clasen wrote:
> > >  II. The rectangle color is currently hardcoded to black, since that looks
> > >      best with the default theme.  Picking a shade of one of the theme
> > >      colors for the rectangle color will not always turn out nice, so
> > >      I think it might be a good idea to add a style property for this
> > >      to GtkTreeView and default to black for the default theme.
> > >
> > 
> > I recently removed one instance of hardcoded black from the treeview
> > dnd code. It would be sad to reintroduce another one now; black does not
> > work in hicolor-inverse and similar themes...

And GtkTreeView uses fg_gc for this now.

> How about working out a shading of the theme colours that works for the
> popular themes (default and some other stock ones), and allow the other
> themes to override it if it looks bad for them.

I've modified the rubberbanding code to use fg[GTK_STATE_NORMAL] as
rubberbanding color and tried some different themes.  This color seems
to look good with all themes I tried, so I would propose to go for using
the fg[NORMAL] color.



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]