Re: gtk_widget_set/get_flags() (Re: GTK_FLOATING broken in 2.9?)

[Matthias Clasen <matthias clasen gmail com>]

On 12/14/05, Tim Janik <timj imendio com> wrote:

On Tue, 13 Dec 2005, Matthias Clasen wrote:

> On 12/13/05, Murray Cumming <murrayc murrayc com> wrote:
>>
>>
>>>
>>> gtkmm 2.8 depends on glib/gtk 2.8, right? then you don't have
>>> g_object_force_floating() there. would it be of any help to you
>>> if glib 2.8 had g_object_force_floating() already (whether function
>>> or not)?
>>
>> Yes, or something in GTK+. Though it would be an act of desparation.
>
>
> One could conceivably modify GTK_OBJECT_SET_FLAGS to do the right thing for
> floating, but
> direct setting/checking of the flag is not fixable.

hmmmmm.

my take on this is that the only way to go this route would be along the
lines of introducing:

void    gtk_widget_set_flags (GtkWidget *widget, guint64 flags);
guint64 gtk_widget_get_flags (GtkWidget *widget);
/* this is reflected by ::notify::flags */

and *deprecating* GTK_OBJECT_SET_FLAGS(), GTK_OBJECT_GET_FLAGS(),
GTK_WIDGET_SET_FLAGS() and GTK_WIDGET_GET_FLAGS() while changing their
implementations to use gtk_widget_*et_flags().

for most flags, modification through GTK_OBJECT_SET_FLAGS() already is wrong
and you should use proeprties instead.

Coincidentally, we have an old bug about deprecating GTK_WIDGET_SET_FLAGS() and
replacing them all by properties...bug 69872.

Matthias