Re: eggtreemodelfilter.c bug fixes

On Sun, 2003-09-07 at 07:34, Kristian Rietveld wrote:
> On Sat, 2003-09-06 at 21:46, David Hampton wrote:
> > 3) egg_tree_model_filter_row_changed needs to build all the tree levels
> > if they don't exist.  As is, it ends up printing a warning message for
> > each node that isn't in an already built level.
> > @@ -1059,7 +1067,7 @@
> >    if (!path)
> >      path = egg_real_tree_model_filter_convert_child_path_to_path (filter,
> >  								  c_path,
> > -								  FALSE,
> > +								  TRUE,
> >  								  TRUE);
> >  
> I have some trouble assuming that this change is right. Which warning
> message is printed exactly?

** (gnucash:6758): CRITICAL **: file eggtreemodelfilter.c: line 1071
(egg_tree_model_filter_row_changed): assertion `path != NULL' failed

> Do you happen to have a small test case reproducing this problem?

Unfortunately, no.  I could probably generate one though.  Do you have
an existing test program for this code that I could modify, or do I need
to write one from scratch?

> I want to find out the real source of this problem before I accept this
> fix. (You don't want to know how easily you can break the filter model
> without noticing ;).

I believe it. I've spent a fair amount of time single stepping through
the code in the last week or two.


Attachment: signature.asc
Description: This is a digitally signed message part

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]