Re: A new type of pango underlining for underlining errors

[Bill Haneman <Bill Haneman Sun COM>]

Hi Nico:

It's really great that you're making this contribution.

While you're at it I would suggest that in order to prevent
accessibility issues, you make sure that the color of the underlining is
not hard-coded; it needs to be themeable if not already in the theme.

Since I don't think we have a GdkStyle gc for this yet, I'd recommend
either reusing an existing style or adding a property which can be set
in the RC file.  Also, the wavy line needs to get thicker for large
fonts.

> Here are two patches that implement the "wavy" underlining.
> 
> The first patch (pango-wave-underline.diff) implements the new pango
> attribute for underlining (called PANGO_UNDERLINE_WAVE).
> 
> The second patch (gtk-wave-underline.diff) contains the corresponding
> changes in the display of the text_view, and a modification in the
> "testtext" program to make use of this new attribute. (To see it in
> action, use the menu Test->Examples).
> 
> Best regards,
> 
> Nico, for the GtkAda team.

> +  if (gdk_color_parse ("red", &red_color))
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
This is an accessibility/theming violation.

Owen, suggestions for how to add this to the GtkStyle or GtkSettings?

- Bill