Re: Patch for io-gif.c

[Federico Mena Quintero <federico ximian com>]

On Sun, 2003-02-23 at 15:13, Matthias Clasen wrote:

> Honestly, I don't feel competent to judge this patch - I didn't write
> the gif loader, and, as Owen points out, this patch changes a lot of
> code.

The patch is actually simple; it just adds a function that clips a
frame's bounding box to that of the base frame, and then has some extra
code so that the functions that fill the pixel buffer take this clipping
into account.

>  It is really unfortunate that we don't have a comprehensive suite
> of test images to validate changes of this kind against. At the very
> least, it would be nice to see some of the broken gifs which should be
> loadable with this patch, and some explanation of the code changes.

Please see this:

	http://bugzilla.gnome.org/show_bug.cgi?id=106962

The attached image loads fine with the patch.  We have been using that
code in the 1.4 branch for about two months now, mainly for Evolution,
and so far it seems to work very well.

  Federico