Re: My take icon icon resizing

[Bill Haneman <bill haneman sun com>]

Owen:

Thanks a million for getting to this.  It really helps us a lot.  And
thanks to Brian for making my patch intelligent enough to update
settings properly.

We will test it of course; I think the questions are around whether it
works OK for apps that register new icon sizes (such as panel), etc.  We
will test it of course but at first glance it looks good.

Please let us know when you put it into CVS so that we can change our
gnome-themes RC files accordingly (to include the '=').

best regards,

Bill

On Fri, 2002-09-20 at 17:26, Owen Taylor wrote:
> 
> Calum Benson <calum benson sun com> writes:
> 
> > On Fri, 2002-09-20 at 00:58, Owen Taylor wrote:
> > > 
> > > Attached is my take on changing the stock icon sizes; it's
> > > basically a complete rewrite from Padraig's patch in:
> > > 
> > >  http://bugzilla.gnome.org/show_bug.cgi?id=70648
> > 
> > Just to double-check... can you confirm that your re-write also
> > addresses the issues in Brian's patch (in the same bug report), which
> > Padraig's original patch didn't fix?
> 
> Sorry Bill/Brian for misattributing the patch ... proves once
> again that relying on memory is a bad idea.
> 
> I think the issues you mention in #70648, #91686, #92852, are
> probably mostly panel issues or issues with how the new icon
> sizes are being selected rather than bugs in Brian's patch.
> 
> (If the setting was set from an RC file, there may be a GTK+
> bug involved ... I don't think reloading RC files currently
> unsets GtkSettings that were set in the last set of RC files.)
> 
> I'd expect my patch should be approximately as robust as 
> changing the font size ... it's possible to break by doing
> the wrong things in applications, but should generally 
> just work.
> 
> Regards,
>                                         Owen