Re: Patch to specify out-of-tree gdk-pixbuf-csource for cross compiling

[Owen Taylor <otaylor redhat com>]

Michael Natterer <mitch gimp org> writes:

> Owen Taylor <otaylor redhat com> writes:
> 
> > Michael Natterer <mitch gimp org> writes:
> > 
> > > > (snip)
> > > 
> > > Oh, I was not aware of that AC_CHECK_PROG() feature.
> > > 
> > > Would you have a look at the attached patch (I used AC_CHECK_PATH(),
> > > because it feels somehow safer :-)
> > 
> > Looks fine. I might do something like:
> > 
> > AM_CONDITIONAL(CROSS_COMPILING, test $build = $host)
> > 
> > Then in the Makefile.am:
> > 
> > if CROSS_COMPILING
> > pixbuf_csource=$(GDK_PIXBUF_CSOURCE)
> > else
> > pixbuf_csource=GDK_PIXBUF_MODULEDIR=$(pixbuf_dir) $(pixbuf_dir)/gdk-pixbuf-csource
> > endif
> > 
> > gtkstockpixbufs.h: $(pixbuf_csource) $(IMAGES)
> > 	$(pixbuf_csource) \
> > 	   --raw --build-list $(VARIABLES1) >$(srcdir)/gtkstockpixbufs.h
> > 
> > To reduce the interdependence between Makefile.am and configure.in, but
> > what you have should work.
> 
> At your service :)
> 
> Are the following patches for glib-genarshal and gdk-pixbuf-csource OK?

Yes, they look fine.
                                        Owen