Re: using GTK_VERSION_CHECK in a preprocessor statement



jacob berkman <jacob ximian com> writes:

> On Mon, 2002-05-06 at 16:54, Owen Taylor wrote:
> > jacob berkman <jacob ximian com> writes:
> > 
> > > On Mon, 2002-05-06 at 16:33, Owen Taylor wrote:
> > > > jacob berkman <jacob ximian com> writes:
> > > > 
> > > > > On Mon, 2002-05-06 at 15:15, Owen Taylor wrote:
> > > > > > jacob berkman <jacob ximian com> writes:
> > > > > >
> > > > > also, forte on solaris gives me:
> > > > > 
> > > > >     "panel-applet-scan.c", line 705: unexpected "("
> > > > >     "panel-applet-scan.c", line 707: warning: improper pointer/integer
> > > > >     combination: op "="
> > > > 
> > > > Are you saying that this goes away when you combine the two lines?
> > > 
> > > on linux, yes.  didn't try on solaris - putting out other, bigger fires
> > > right now.
> > 
> > OK, well, when you have more time, I"d appreciate if you could investigate
> > further. I can believe that either GCC or Forte would be non-conformant
> > with the X standard in some odd cases, but I have trouble believing that
> > both of them would have have problem with exactly the same case.
> 
> the attached (committed) patch fixed it.
> 
> thanks for keeping me on the right track.

:-) Looks good to commit. 

Thanks for tracking this down,
                                        Owen

> Index: gtkdoc-scangobj.in
> ===================================================================
> RCS file: /cvs/gnome/gtk-doc/gtkdoc-scangobj.in,v
> retrieving revision 1.24
> diff -u -r1.24 gtkdoc-scangobj.in
> --- gtkdoc-scangobj.in	5 May 2002 20:10:37 -0000	1.24
> +++ gtkdoc-scangobj.in	6 May 2002 21:05:05 -0000
> @@ -100,6 +100,9 @@
>  #include <stdio.h>
>  
>  $includes
> +#ifdef GTK_IS_WIDGET_CLASS
> +#include <gtk/gtkversion.h>
> +#endif
>  GType object_types[$ntypes];
>  
>  GType *



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]