Re: bug 84241

James Henstridge <james daa com au> writes:

> I would like to see bug 84241 fixed in gtk 2.2 and possibly also on
> the 2.0.x branch.
> The gtk_menu_item_set_accel_path() can be used to set the accel path
> on a menu item, but not unset it.  In contrast,
> gtk_widget_set_accel_path() can unset the accel path on a widget.
> However, for menu items, unsetting with gtk_widget_set_accel_path(),
> the old accel path is still stored in menu_item->accel_path.
> After reading the gtk_menu_item_set_accel_path(), it looks like the
> only thing stopping it from being used is one of the assertions at the
> top. I gave a possible replacement assertion in the comments of the
> bug:
> The reason I want to be able to do this is for my menu merge code in
> libegg.  I have functions to connect and disconnect a menu item to a
> particular action object.  When disconnecting, I want to unset the
> accel path if at all possible.

I think it's pretty obviously right for HEAD, but not so clear if
it's something we should add to stable. The somewhat philosophical
question is:

 Is it a bug where the "set to NULL to remove" functionality is
 there but just doesn't work. Or it a feature addition that is
 just really easy to implement.

Since it isn't mentioned in the docs I'd tend to say it is the

If we add a new feature in the 2.0.x series, then suddenly, your
code will have a dependency on GTK+-2.0.4 (or 5) which is something
we are trying to avoid as much as possible.

So, my instict is "HEAD only and add the new feature to the docs
at the same time".


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]