Re: [PATCH] glib configure.in patches

[Owen Taylor <otaylor redhat com>]

Art Haas <ahaas neosoft com> writes:

> I thought I'd toss this patc out and see if there is any interest
> in the "fixes" it contains. As the configure.in script for
> glib requires autoconf-2.5X, I modified the configure.in file
> to better follow the recommended macros in the latest autoconf.

Thanks a lot for doing this work; I must admit I'm not entirely
enthusiastic about autoconf cleanup changes. autoconf is one
of those "if it isn't broke...." things. But I guess we
should try and move forward with autoconf.

(I'd be happier if autoconf just didn't change, really.)

[...]
 
> This patch is against the glib-2-branch, not against the
> head. I don't know whether or not the patch applies directly
> to the head, as I'm sticking with the branch for now. I
> also have similar patches for atk, pango, and gtk+ which
> I'll be glad to forward along if there's interest. 

I'm not going to apply any changes like this to the glib-2-0
branch. I don't really have time to merge it to HEAD myself.
(My guess is that it will 90% apply cleanly and 10% not.)
So I need to someone to merge it if it is going to get applied.

> diff -u -r1.279.2.11 configure.in
> --- configure.in	18 Jun 2002 18:28:25 -0000	1.279.2.11
> +++ configure.in	21 Jun 2002 20:36:39 -0000
> @@ -9,7 +9,8 @@
>  AC_PREREQ(2.52)
>  
>  # Process this file with autoconf to produce a configure script.
> -AC_INIT(glib/glib.h)
> +AC_INIT([glib], [2.0.4])
                    ^^^^^
Not an acceptable change; the version information has to be only in
one place.

> +AC_CONFIG_SRCDIR(glib/glib.h)

[...]

>  dnl declare --enable-* args and collect ac_help strings
> -AC_ARG_ENABLE(debug, [  --enable-debug=[no/minimum/yes] turn on debugging [default=$debug_default]],,enable_debug=$debug_default)

> +AC_ARG_ENABLE([debug],
> +              AC_HELP_STRING([--enable-debug=@<:@no/minimum/yes@:>@],
> +	                     [turn on debugging @<:@default=$debug_default@:>@]),
> +	      [],
> +	      [enable_debug=$debug_default])

Ugh, these 'quadriglyphs' are incredibly unreadable. I assume the
problem is that AC_HELP_STRING does multiple levels of expansion on
it's arguments?

> @@ -237,8 +260,8 @@
>    fi
>  fi
>  
> -AC_CYGWIN
> -AC_EXEEXT
> +dnl AC_CYGWIN
> +dnl AC_EXEEXT

Commenting out macros does nothing but create confusion.
If they aren't needed any more, they need to be removed.
  
> @@ -751,7 +778,9 @@
>  if test "$gtk_ok" = "yes"; then
>      AC_MSG_RESULT([yes, found in sys/types.h])
>  else
> -    AC_EGREP_HEADER(fd_set, sys/select.h, gtk_ok=yes)
> +    AC_EGREP_HEADER([fd_set],
> +                    [sys/select.h],
> +                    [gtk_ok=yes])

Why this change? It's really important to keep patches as small
as possible, and as much "only one thing per patch", or they
are a lot harder to review. There are a bunch of places
where you've added extra qutoting for  no apparent reason.

Regards,
                                        Owen