Re: Range patchlet

[Owen Taylor <otaylor redhat com>]

Bill Haneman <bill haneman sun com> writes:

> Hi:
> 
> Here is a two-line patch that fixes a small bug in the gtkrange focus
> drawing - note that without this patch, the focus indication is only
> visible on the left and top edges, and is clipped out of the right and
> bottom edges.  With this patch the focus indication is contained
> correctly inside the slider rectangle.
> 
> OK to commit ?

Well:

 * I can't reproduce this bug.
 * I can't see why I should be able to reproduce this bug; the previous
   geometry should be fine. (Is this a left-over from before we changed
   the interpretation of the rectangle passed to paint focus?)

Regards,
                                        Owen
 
> -BillIndex: gtk/gtkrange.c
> ===================================================================
> RCS file: /cvs/gnome/gtk+/gtk/gtkrange.c,v
> retrieving revision 1.74
> diff -u -r1.74 gtkrange.c
> --- gtk/gtkrange.c	2002/01/09 10:28:02	1.74
> +++ gtk/gtkrange.c	2002/01/24 14:18:16
> @@ -922,8 +922,8 @@
>                           &area, widget, "trough",
>                           widget->allocation.x + range->range_rect.x,
>                           widget->allocation.y + range->range_rect.y,
> -                         range->range_rect.width,
> -                         range->range_rect.height);
> +                         range->range_rect.width - 1,
> +                         range->range_rect.height - 1);
>      }
>  
>    if (!sensitive)