Bugs in gdkkeys-x11.c? (Was: gtk+ keynav screwed (at least on win32))



Isn't this code wrong:

 return XKeycodeToKeysym (gdk_display, key->keycode,
                          key->group * keysyms_per_keycode + key->level);

and
 tmp_keyval = XKeycodeToKeysym (gdk_display, hardware_keycode,
                                group * keysyms_per_keycode + shift_level);
Shouldn't that be 

 return XKeycodeToKeysym (gdk_display, key->keycode,
                          key->group * keysyms_per_keycode/2 + key->level);

and
 tmp_keyval = XKeycodeToKeysym (gdk_display, hardware_keycode,
                                group * keysyms_per_keycode/2 + shift_level);

(assuming there are two levels per group, as the code does in some
other places)

--tml




[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]