Re: pixbuf scaling



Matthias Clasen <maclas gmx de> writes:

> Here is a corrected version of the patch. Unfortunately, I'm not
> very good at making up names for helper functions...

correct_total() sounds perfect to nme.

> Index: pixops.c
> ===================================================================
> RCS file: /cvs/gnome/gtk+/gdk-pixbuf/pixops/pixops.c,v
> retrieving revision 1.25
> diff -u -b -B -p -r1.25 pixops.c
> --- pixops.c	2002/02/11 19:36:12	1.25
> +++ pixops.c	2002/02/14 22:54:06
> @@ -1077,6 +1077,20 @@ pixops_process (guchar         *dest_buf
>    g_free (line_bufs);
>  }
>  
> +static void correct_total (int *weights, int n, int total, double overall_alpha)

Needs to be:

static void
correct_total (int   *weights,
               int    n,
               int    total,
               double overall_alpha)

I think separate n_x, n_y would be better.

Other than that, looks fine to commit.

Regards,
                                        Owen



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]