Re: pixbuf scaling

[Owen Taylor <otaylor redhat com>]

Matthias Clasen <maclas gmx de> writes:

> Hi Owen, 
> 
> I think I found the reason for the recent problems with pixbuf scaling:
> Your correction to force the weights to sum to 65536 can make the last
> weight negative, which is not well received by the line functions which 
> operate on unsigned variables.
> 
> I have appended an impressive demonstration of the problem (
> gtk+/demos/testpixbuf-scale gtk+/gtk/stock-icons/dialog_warning.png
> ) and a possible fix.

This sounds like a correct diagnosis. Two comments on the patch:

 - There are three places where the correction is applied. There
   only seems to be two in the patch.

 - I think it would be better to have a function to do the correction
   rather than repeat the code three times.
   
[ And indentation problems :-) ]

Regards,
                                             Owen