RE: 24 small bugs



  Hi 
  I was looking into the hscale/vscale bug .(bug id #61743 )
  
  I think in the gtk_hscale_expose and gtk_vscale_expose function 
  we can call the expose_event for the parent_class in the beginning instead of at
  the end of the function . This will solve the issue. 
 
  Here is the attached diff . Please go through it .
  Expecting your comments.
 
  Regards
  Satyajit

  --- gtk+/gtk/gtkhscale.c	Tue Feb 12 06:56:17 2002
+++ gtk+_new/gtk/gtkhscale.c	Wed Feb 13 06:56:59 2002
@@ -169,6 +169,10 @@
       GtkStateType state_type;
       gint value_spacing;
 
+      if (GTK_WIDGET_CLASS (parent_class)->expose_event)
+          GTK_WIDGET_CLASS (parent_class)->expose_event(widget, event);
+
+
       gtk_widget_style_get (widget, "value_spacing", &value_spacing, NULL);
       
       txt = _gtk_scale_format_value (scale,
@@ -231,6 +235,5 @@
 
       g_object_unref (G_OBJECT (layout));
     }
-
-  return (* GTK_WIDGET_CLASS (parent_class)->expose_event) (widget, event);
+    return FALSE;
 }
--- gtk+/gtk/gtkvscale.c	Tue Feb 12 06:56:17 2002
+++ gtk+_new/gtk/gtkvscale.c	Wed Feb 13 06:57:10 2002
@@ -171,6 +171,8 @@
       GtkStateType state_type;
       gint value_spacing;
 
+      if (GTK_WIDGET_CLASS (parent_class)->expose_event)
+          GTK_WIDGET_CLASS (parent_class)->expose_event(widget, event);
       gtk_widget_style_get (widget, "value_spacing", &value_spacing, NULL);
       
       txt = _gtk_scale_format_value (scale,
@@ -232,5 +234,5 @@
       g_object_unref (G_OBJECT (layout));
     }
   
-  return (* GTK_WIDGET_CLASS (parent_class)->expose_event) (widget, event);
+  return FALSE;
 }
 
  
> From Owen Taylor
> Subject: 24 small bugs



>Here are some open bugs that I think should be easy to fix - most of
>the work for many of these should be creating an appropriate test
>case.
>61743 gtk      gtk+    2.0.0   HScale/VScale label display always one step behind                                       

**************************Disclaimer************************************
      


Information contained in this E-MAIL being proprietary to Wipro Limited
is 'privileged' and 'confidential' and intended for use only by the
individual or entity to which it is addressed. You are notified that any
use, copying or dissemination of the information contained in the E-MAIL
in any manner whatsoever is strictly prohibited.



 ********************************************************************


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]