Re: [patch] color picker crash

[Erwann Chenede <Erwann Chenede Sun COM>]

[...]

>
>It's not clear to me why gdk_x11_drawable_get_xdisplay() can
>handle an "impl" object .... I think it's best to say impls
>are impls, and wrapper drawable are wrapper drawables and
>they aren't interchangable.
>
>gdk_x11_drawable_get_xdisplay() is essentially a public function
>and the impl objects are never revealed publically.
>
>There are all sorts of different ways the display is referneced
>in that function.
>
>    XFlush (GDK_DRAWABLE_DISPLAY (drawable)); [ seriously messed up... ]
>
>    Display *xdisplay = GDK_SCREEN_XDISPLAY (impl->screen); 
>      XTranslateCoordinates (GDK_SCREEN_XDISPLAY (impl->screen),
>
>      XFlush (GDK_DRAWABLE_XDISPLAY (drawable));
>
>What I think is right is to add, after:
>
>   impl = GDK_DRAWABLE_IMPL_X11 (drawable);
>
>   display = gdk_screen_get_display (impl->screen);
>   xdisplay = GDK_DISPLAY_XDISPLAY (display)
>
>And use those variables throughout the function.

Boy, the multihead related code was all over the place 
in this function.
I've cleaned it and fixed
http://bugzilla.gnome.org/show_bug.cgi?id=80256
(patch attached in bugzilla).

Is it ok to commit ?

	Regards,
		Erwann
		
 Erwann Chénedé, Sun Microsystems, Ireland
 Phone  : +353 1 8199031         xt: 19031
[ I speak for myself, not for my employer ]