Re: patch for GtkDialog

[James Willcox <jwillcox cs indiana edu>]

On Sun, 2002-03-31 at 16:32, Havoc Pennington wrote:
> 
> Hi,
> 
> The patch looks good to me except that we're still "eating" the Escape
> key here; is that OK? Or should we be passing it through?

So, passing it through would allow it to be bound to something else,
right?  I think this could lead to confusion.....what do UI people
think?

> To pass it through, we'd need to add a new keybinding signal 
> activate_cancel or the like, and return TRUE/FALSE from that according
> to whether we have cancel. The new signal can be added without using a
> slot in GtkDialogClass, Owen can post his hack for that maybe...
> 
> This raises a small question, should Escape result in
> GTK_RESPONSE_CANCEL then, rather than GTK_RESPONSE_DELETE_EVENT?

This seems resonable.

Thanks,
James