Re: typo in gtktexttag.c - patch



Kristian Rietveld <kristian planet nl> writes:

> Hi,
> 
> gtk-demo gave g_warnings. I traced it down to a typo in gtktexttag.c (font
> weight is an enum not an int). Appended patch fixes this.
> 
> Ok to commit?

Actually, it's an int with some predefined values. The getters/setters
need to be fixed instead. (You can use a weight of 655 or whatever
if you so desire.)

                                        Owen
> Index: gtktexttag.c
> ===================================================================
> RCS file: /cvs/gnome/gtk+/gtk/gtktexttag.c,v
> retrieving revision 1.46
> diff -u -r1.46 gtktexttag.c
> --- gtktexttag.c	2001/09/19 00:58:09	1.46
> +++ gtktexttag.c	2001/09/22 13:46:58
> @@ -323,13 +323,12 @@
> 
>    g_object_class_install_property (object_class,
>                                     PROP_WEIGHT,
> -                                   g_param_spec_int ("weight",
> -                                                     _("Font weight"),
> -                                                     _("Font weight"),
> -                                                     0,
> -                                                     G_MAXINT,
> -                                                     PANGO_WEIGHT_NORMAL,
> -                                                     G_PARAM_READABLE | G_PARAM_WRITABLE));
> +                                   g_param_spec_enum ("weight",
> +						      _("Font weight"),
> +						      _("Font weight"),
> +						      PANGO_TYPE_WEIGHT,
> +						      PANGO_WEIGHT_NORMAL,
> +						      G_PARAM_READABLE | G_PARAM_WRITABLE));




[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]