Properties for draw_focus [was: Re: #54720 -button children should optionally move]]]]

[Bill Haneman <bill haneman sun com>]

[Oops, resending due to reply-to problem]

timj wrote about child_displacement_x and child_displacement_y
in the context of theming (see below):

In a similar vein, it would be a great convenience for focus-drawing 
lines to be styleable using the "standard" theme engines.  

The default focus box is not suitable for high-contrast themes or
moderately-low-vision (i.e. "big font/bold lines") themes.

Though I realize a new theme engine could override draw_focus easily,
it would be pretty simple to make the focus color, dotted-line-style,
or at least line width properties, and this way gtkrc files could
accomplish the same thing for standard themes.

If this sounds acceptable I would be happy to provide a patch
for gtk_default_draw_focus.

-Bill


> Date: Thu, 23 Aug 2001 16:43:17 +0200 (CEST)
> From: Tim Janik <timj gtk org>
> To: Owen Taylor <otaylor redhat com>
> Cc: Gtk+ Developers <gtk-devel-list gnome org>, sandmann daimi au dk
> Subject: Re: #54720 -button children should optionally move
> 
> On 22 Aug 2001, Owen Taylor wrote:
> 
> > Remaining possible questions about this patch:
> >
> >  * Should we have separate child_displacement_x/child_displacement_y
> >    properties? Does it ever make sense for them to be separate
> 
> i think the argument already given, a theme wanting to change the
> angle of the virtual light source generating shading, suggests that
> this is necessary.
> 
> >  * Should _gtk_button_set_depressed() be exported? If someone wanted
> >    to write a like-toggle-button widget right now, they wouldn't
> >    be able to. On the other hand, making it public is inviting
> >    confusion and abuse.
> 
> definitely not, i already came across apps that hacked this into
> their widgets, so i'm pretty sure people will abuse this in
> their programs instead of going through rc files.
> 
> >
> > Regards,
> >                                         Owen
> >
> 
> ---
> ciaoTJ