Re: [patch] leak in pango_font_description_set_family()

[Owen Taylor <otaylor redhat com>]

Sven Neumann <sven gimp org> writes:

> Hi,
> 
> me and memprof think pango_font_description_set_family() needs the 
> following patch so subsequent calls will free the family_name
> correctly:
> 
> Index: pango/fonts.c
> ===================================================================
> RCS file: /cvs/gnome/pango/pango/fonts.c,v
> retrieving revision 1.30
> diff -u -r1.30 fonts.c
> --- pango/fonts.c	2001/09/20 12:01:52	1.30
> +++ pango/fonts.c	2001/09/20 14:43:26
> @@ -108,6 +108,7 @@
>      {
>        desc->family_name = g_strdup (family);
>        desc->mask |= PANGO_FONT_MASK_FAMILY;
> +      desc->static_family = FALSE;
>      }
>    else
>      {

Hmm, yeah. Could you fix this, and also make the corresponding
change in pango_font_description_copy()? 

Thanks,
                                        Owen