Re: GtkCList: crash fix and api question

[Owen Taylor <otaylor redhat com>]

jacob berkman <jacob ximian com> writes:

> here's a fix for a crash i got when using GtkCList.

Please commit.

> gtk_clist_construct() also changed incompatibly - should it be changed
> back?

It would be nice if it remained compatible, yes. (I agree changing a
deprecated widget should be avoided.) I'm not sure how easy that would
be to fit into the new GObject construction framework.

If you can come up with a reasonable patch to restore gtk_clist/ctree_construct,
I'd be in favor of adding it. 

(Note though, that one major usage of these functions is language bindings,
which have to be majorly rewritten and probably would be happier if 
the widgets fitted into the new framework properly.)

Regards,
                                        Owen

> Index: gtkclist.c
> ===================================================================
> RCS file: /cvs/gnome/gtk+/gtk/gtkclist.c,v
> retrieving revision 1.205
> diff -u -r1.205 gtkclist.c
> --- gtkclist.c	2001/09/19 00:49:51	1.205
> +++ gtkclist.c	2001/10/22 04:12:15
> @@ -2618,6 +2618,11 @@
>    switch (clist_row->cell[column].type)
>      {
>      case GTK_CELL_PIXTEXT:
> +      gdk_window_get_size (GTK_CELL_PIXTEXT (clist_row->cell[column])->pixmap,
> +			   &width, &height);
> +      requisition->width += width;
> +      requisition->height = MAX (requisition->height, height);      
> +      break;
>      case GTK_CELL_PIXMAP:
>        gdk_window_get_size (GTK_CELL_PIXMAP (clist_row->cell[column])->pixmap,
>  			   &width, &height);