Re: [Re: [PATCH] GtkInputDialog signal parameter types]

[Murray Cumming <murrayc usa net>]

Tim Janik <timj gtk org> wrote:
> On 15 Oct 2001, Murray Cumming wrote:
> 
> > Here's a simple patch that creates the enable-device and enable-device
signals
> > with correct parameter types. I assume that the declaration of the
default
> > signal handler is the correct one. 
> 
> hum, i fail to see where these signals are being emitted, and they
> don't contain the conventional function wrappers:
> 
> void gtk_input_dialog_enable_device  (GtkInputDialog    *inputd,
>                                       GdkDevice         *device);
> void gtk_input_dialog_disable_device (GtkInputDialog    *inputd,
>                                       GdkDevice         *device);
> 
> but aren't action signals either.
> so i wonder whether:
> - these signals are used anywhere in user code directly
>   (in which case the above wrappers should be added and
>   direct emission should be deprecated)

Owne had previously told me that these types of functions are not necessarily
just signal-emmiting functions. Can you confirm that methods with the same
name as signals might do more than just emit the signal? It's relevant to the
language bindings.

> - these signals should simply be removed as they don't seem
>   to be used.
> 
> owen, can you comment on this?
> 
> > 
> > Murray Cumming
> > murrayc usa net
> > www.murrayc.com
> > 
> 
> ---
> ciaoTJ
> 


Murray Cumming
murrayc usa net
www.murrayc.com