GtkNotebook - set label bug ...
- From: Michael Meeks <michael ximian com>
- To: Cristiano De Michele <cristiano demichele na infn it>
- Cc: <gtk-devel-list gnome org>
- Subject: GtkNotebook - set label bug ...
- Date: Thu, 8 Nov 2001 01:24:50 -0500 (EST)
Hi Cristiano,
The bestt place to send Gtk+ bug reports is here, the fix
looks fine to me; you really need a ChangeLog entry too.
Well found,
Michael.
--
mmeeks gnu org <><, Pseudo Engineer, itinerant idiot
---------- Forwarded message ----------
Date: Thu, 08 Nov 2001 00:32:29 +0100
From: Cristiano De Michele <cristiano demichele na infn it>
To: Michael Meeks <michael ximian com>
Subject: signal warnings
... so I started using gdb always following your hints and here's
what I got: the g_signal.c warnings were due to a bug in
gtknotebook.c, in fact if one created a new label via
gtk_notebook_set_label the mnemonic signal wasn't connected to the
newly created label so that destroying the tab label it tried to
disconnect the signal getting the warning from glib, that's all I
fixed that one connecting the signal to the tab label in
gtknotebook.c:gtk_notebook_set_tab_label(...) (in attachment) now it's
p(t)ango time!
...
Index: gtknotebook.c
===================================================================
RCS file: /cvs/gnome/gtk+/gtk/gtknotebook.c,v
retrieving revision 1.98
diff -u -r1.98 gtknotebook.c
--- gtknotebook.c 2001/09/26 20:33:23 1.98
+++ gtknotebook.c 2001/11/07 22:29:14
@@ -4530,8 +4530,15 @@
gtk_notebook_real_page_position (notebook, list));
page->tab_label = gtk_label_new (string);
gtk_widget_set_parent (page->tab_label, GTK_WIDGET (notebook));
+
}
}
+ page->mnemonic_activate_signal =
+ gtk_signal_connect (GTK_OBJECT (tab_label),
+ "mnemonic_activate",
+ (GtkSignalFunc)
gtk_notebook_mnemonic_activate_switch_page,
+ notebook);
+
if (notebook->show_tabs && GTK_WIDGET_VISIBLE (child))
{
--
mmeeks gnu org <><, Pseudo Engineer, itinerant idiot
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]