gtk_window_set_transient_for

[Jeff Franks <jcf tpg com au>]

Hi,

The 'gtk_window_set_transient_for' function doesn't seem to work the
same way as in version 1.2.8. Examining gtkwindow.c I
noticed that the g_return_if_fail checks at the beginning of the
function body are different.

Originally in 1.2.8:
	
void gtk_window_set_transient_for(GtkWindow *window, GtkWindow *parent)
{
	g_return_if_fail(window != 0);
	...
	...
}

And now in 1.3.3:

void gtk_window_set_transient_for(GtkWindow *window, GtkWindow *parent)
{
	g_return_if_fail(GTK_IS_WINDOW(window));
	g_return_if_fail(parent == NULL || GTK_IS_WINDOW(parent))
	g_return_if_fail(window != parent);
	...
	...
}

Wont this function now fail if parent is anything other than NULL?
Further down the function body there is an 'if (parent)' statement which
suggests that you could set 'parent' to NULL or a pointer value.
Shouldn't the second line be omitted altogether?

Thanks

Jeff.















Thanks,

Jeff.