Re: Xft and Xrender support for GTK+ 1.2.8

[Havoc Pennington <hp redhat com>]

"Bryan O'Sullivan" <bos serpentine com> writes: 
> Please send feedback and corrections my way, as I'd like to see this
> stuff get integrated into the "legacy" (as opposed to CVS current)
> GTK+ tree at some point.
> 

You might want to mail jacob ximian com who was also hacking on a
patch for this.

I think it's important to know what stability guarantees Keith is
ready to make for Xft. If Xft is likely to change bin/source compat
over time? Is there a way for a compiled GDK to check for that? Maybe
Owen already knows the plan there. Anyway, we can't have stuff in
stable GTK that could start segfaulting on an X upgrade.

Glancing at the patch quickly,

+ *   GDK_FONT_XFT_FONT: the font is an XftFontStruct.
+ *   GDK_FONT_XFT_FONTSET: the font is an XftFontSet used for I18N.
  */
 typedef enum
 {
   GDK_FONT_FONT,
-  GDK_FONT_FONTSET
+  GDK_FONT_FONTSET,
+  GDK_FONT_XFT_FONT,
+  GDK_FONT_XFT_FONTSET
 } GdkFontType;
 
This could break existing code - think of a switch:

 switch (font->type)
  {

 default:
   g_assert_not_reached();
  }

The conditionally-changing struct size in gdkprivate.h won't work
either, because that file gets installed and used, despite its name.
(Also, gdkprivate.h shouldn't include config.h for that reason.)

Don't you need to check in gdk_init() whether the server supports the
Xft extension, in addition to checking whether Xlib supports it at
build time?

Havoc