Re: unneeded buggy code in gdk-pixbuf PGN saving
- From: Owen Taylor <otaylor redhat com>
- To: Michael Natterer <mitch gimp org>
- Cc: Havoc Pennington <hp redhat com>, gtk-devel-list gnome org
- Subject: Re: unneeded buggy code in gdk-pixbuf PGN saving
- Date: 11 Dec 2001 10:49:51 -0500
Michael Natterer <mitch gimp org> writes:
> Owen Taylor <otaylor redhat com> writes:
>
> > (...)
> >
> > Maybe you could extend testpixbuf-save to test the alpha case? Also,
> > if you are using this code, you probably want to fix the silly:
> >
> > for (j = 0, x = 0; x < w; x++)
> > memcpy (&(data[x*3]), &(ptr[x*3]), 3);
>
> Done.
>
> The patch has become a bit lenghty :) ok to commit?
Looks good to me,
Owen
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]