Re: [patch] fix g_shell_quote

[Havoc Pennington <hp redhat com>]

Darin Adler <darin bentspoon com> writes:
> Converting eel to the new glib, I converted eel_shell_quote to
> g_shell_quote. Rather than discard the tests for eel_shell_quote, I ran them
> on g_shell_quote and discovered that it doesn't work.
> 
> Index: glib/gshell.c
> ===================================================================
> RCS file: /cvs/gnome/glib/glib/gshell.c,v
> retrieving revision 1.3
> diff -p -u -r1.3 gshell.c
> --- glib/gshell.c	2001/03/09 21:23:33	1.3
> +++ glib/gshell.c	2001/08/16 00:07:50
> @@ -198,7 +198,7 @@ g_shell_quote (const gchar *unquoted_str
>       {
>         /* Replace literal ' with a close ', a \', and a open ' */
>         if (*p == '\'')
> -        g_string_append (dest, "'\''");
> +        g_string_append (dest, "'\\''");
>         else
>           g_string_append_c (dest, *p);
> 
> ===================================================================
> 
> May I commit?
> 

Looks good. Maybe also fix shell-test.c to trigger this?

Havoc