Re: Outstanding patches, #58330

["Matthias Clasen" <matthiasc poet de>]

----- Original Message -----
From: "Tim Janik" <timj gtk org>
To: "Matthias Clasen" <matthiasc poet de>
Cc: "Gtk+ Developers" <gtk-devel-list gnome org>
Sent: Monday, August 13, 2001 12:39 PM
Subject: Re: Outstanding patches, #58330


> On Mon, 13 Aug 2001, Matthias Clasen wrote:
>
> > Here is a patch removing unused debug flags, parallel to the
debugging.txt
> > update.
> > Doing this lead to the discovery that some of the seemingly unused debug
> > flags
> > are in fact used only via GDK_NOTE/GTK_NOTE.
>
> actually pretty much all debug stuff should go through G?K_NOTE().
>
> >

I guess some knowledge about this has been lost...
the two major new widgets in gtk+-2.0 are the major violators of this rule:

gtkliststore.c:  if (gtk_debug_flags & GTK_DEBUG_TREE)
gtkrbtree.c:  if (gtk_debug_flags & GTK_DEBUG_TREE)
gtkrbtree.c:  if (gtk_debug_flags & GTK_DEBUG_TREE)
gtkrbtree.c:  if (gtk_debug_flags & GTK_DEBUG_TREE)
gtkrbtree.c:  if (gtk_debug_flags & GTK_DEBUG_TREE)
gtkrbtree.c:  if (gtk_debug_flags & GTK_DEBUG_TREE)
gtkrbtree.c:  if (gtk_debug_flags & GTK_DEBUG_TREE)
gtkrbtree.c:  if (gtk_debug_flags & GTK_DEBUG_TREE)
gtkrbtree.c:  if (gtk_debug_flags & GTK_DEBUG_TREE)
gtkrbtree.c:  if (gtk_debug_flags & GTK_DEBUG_TREE)
gtktextbtree.c:  if (gtk_debug_flags & GTK_DEBUG_TEXT)
gtktextbtree.c:  if (gtk_debug_flags & GTK_DEBUG_TEXT)
gtktextbtree.c:  if (gtk_debug_flags & GTK_DEBUG_TEXT)
gtktextbtree.c:  if (gtk_debug_flags & GTK_DEBUG_TEXT)
gtktextbtree.c:  if (gtk_debug_flags & GTK_DEBUG_TEXT)
gtktextbtree.c:  if (gtk_debug_flags & GTK_DEBUG_TEXT)
gtktextbtree.c:  if (gtk_debug_flags & GTK_DEBUG_TEXT)
gtktextbtree.c:  if (gtk_debug_flags & GTK_DEBUG_TEXT)
gtktextbtree.c:  if (gtk_debug_flags & GTK_DEBUG_TEXT)
gtktextbtree.c:      if (gtk_debug_flags & GTK_DEBUG_TEXT)
gtktextbtree.c:  if (gtk_debug_flags & GTK_DEBUG_TEXT)
gtktextbtree.c:  if (gtk_debug_flags & GTK_DEBUG_TEXT)
gtktextiter.c:  if (gtk_debug_flags & GTK_DEBUG_TEXT)
gtktextsegment.c:  if (gtk_debug_flags & GTK_DEBUG_TEXT)
gtktextsegment.c:  if (gtk_debug_flags & GTK_DEBUG_TEXT)
gtktextsegment.c:  if (gtk_debug_flags & GTK_DEBUG_TEXT)
gtktextsegment.c:  if (gtk_debug_flags & GTK_DEBUG_TEXT)
gtktextsegment.c:  if (gtk_debug_flags & GTK_DEBUG_TEXT)
gtktextsegment.c:  if (gtk_debug_flags & GTK_DEBUG_TEXT)
gtktextsegment.c:  if (gtk_debug_flags & GTK_DEBUG_TEXT)
gtktreestore.c:  if (gtk_debug_flags & GTK_DEBUG_TREE)