Re: Outstanding patches, #58604

["Matthias Clasen" <matthiasc poet de>]

I've committed it with the obvious fix mentioned below.

Matthias

----- Original Message ----- 
From: "Owen Taylor" <otaylor redhat com>
To: "Matthias Clasen" <matthiasc poet de>
Cc: <gtk-devel-list gnome org>
Sent: Tuesday, August 07, 2001 9:58 PM
Subject: Re: Outstanding patches, #58604


> Looks fine to me. I'd slightly prefer to see:
> 
> ===
> /* Map handler for the HSV color selector */
> 
> static void
> gtk_hsv_map (GtkWidget *widget)
> {
>   GtkHSV *hsv;
>   HSVPrivate *priv;
> 
>   hsv = GTK_HSV (widget);
>   priv = hsv->priv;
> 
>   GTK_WIDGET_CLASS (parent_class)->map (window);

You probably mean widget here, not window. Otherwise it won't compile.

> 
>   gdk_window_show (priv->window);
> }
> 
> /* Unmap handler for the HSV color selector */
> 
> static void
> gtk_hsv_unmap (GtkWidget *widget)
> {
>   GtkHSV *hsv;
>   HSVPrivate *priv;
> 
>   hsv = GTK_HSV (widget);
>   priv = hsv->priv;
> 
>   gdk_window_hide (priv->window);
> 
>   GTK_WIDGET_CLASS (parent_class)->unmap (window);

Here too.

> }
> ===
> 
> Doesn't really matter here ... but is a bit better
> stylistically.
> 
> Regards,
>                                         Owen
> 
>