Re: glib (2.0) fixes and darwin porting

Hi Dan,

> I'm enclosing two sets of patches (against the glib mainline): the first
> is all generic portability/bugfixing/sanity stuff. 

I have one question. 

> -    AC_TRY_COMPILE([#include <time.h>],
> -       [time_t t; char b[30]; ctime_r (&t, b);], ,
> -           [AC_TRY_COMPILE([#include <time.h>],
> -               [time_t t; char b[30]; ctime_r (&t, b, 30);], ,
> -                       AC_MSG_WARN($FLAG_DOES_NOT_WORK))])
> +    AC_EGREP_CPP(ctime_r, [#include <time.h>], ,

Is that necessary for Darwin? I rememver to have changed it that way to make
it also recognise macros and not only function declarations of that name. I
would really like to keep it that way.
> OK to commit?

The rest of glib-fixes.diff looks OK and seems safe to commit. I can't really
say much about glib-gyld.diff. That should be done by Tim I suppose.

Sebastian Wilhelmi
mailto:wilhelmi ira uka de

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]