While looking through gcompletion.c, a few things stick out:

#1, why can you only add/remove multiple items at a time?  This
forces the user of a GCompletion to keep an extra GList, if they're
getting items one at a time (ie, if using readdir() or something).
Would the addition of g_completion_{add,remove}_item() be accepted?

#2, what's the reasoning for GCompletionStrncmpFunc?  It seems as
it's either a bulky way to allow the user to do case-insensitive
matching; any replacing (~, $VARIABLE) should be done before
before g_completion_complete() is ever passed a prefix, so I really
can't see a use for it.  Could someone please enlighten me?  If
it is simply for the possibility of case-insensitive matching, would
a patch to use a boolean value instead be accepted?

(These are both API changes, which is why I'm asking before starting)

"... being a Linux user is sort of like living in a house inhabited
by a large family of carpenters and architects. Every morning when
you wake up, the house is a little different. Maybe there is a new
turret, or some walls have moved. Or perhaps someone has temporarily
removed the floor under your bed." - Unix for Dummies, 2nd Edition
        -- found in the .sig of Rob Riggs, rriggs tesser com

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]