Re: dragging bug caused by fix for GtkInvisible style attach leak

[Tim Janik <timj gtk org>]

On 29 Dec 2000, Havoc Pennington wrote:

> So the possible fixes are:
>  a) allow GtkInvisible not to have a style (revert Alex's change) and 
>     allow widget->style to be NULL or whatever the problem was there
>     (i.e. special case invisible widgets)
>  b) allow input-only windows to have a colormap and set the colormap
>     for GtkInvisible's window
>  c) special-case input only windows somehow (either in all code 
>     using window->colormap, or maybe gdk_drawable_get_colormap()
>     would return the default cmap for input-only windows - putting 
>     the special case in only one spot)
> 
> Since everyone is out of town it's likely I should check in a quick
> fix of some kind for the short term, I guess the smallest possible fix
> is b)

i'd prefer c), special casing in one place, i.e.
gdk_drawable_get_colormap(). generic code probably doesn't expect
a valid window to not have a colormap, and no code should freak around
with gdkwindow internals ao much to find out it doesn't actually have
a colormap pointer. of course on this, owen has the final say, but
i think just patching up get_colormap() is the best idea here.

> 
> Thanks for catching this prior to 1.2.9
> 
> Havoc
> 

---
ciaoTJ