Re: dragging bug caused by fix for GtkInvisible style attach leak



Darin Adler <darin eazel com> writes:
> on 12/29/00 2:14 PM, Havoc Pennington at hp redhat com wrote:
> 
> > So the possible fixes are:
> >  a) allow GtkInvisible not to have a style (revert Alex's change) and
> >     allow widget->style to be NULL or whatever the problem was there
> >     (i.e. special case invisible widgets)
> >  b) allow input-only windows to have a colormap and set the colormap
> >     for GtkInvisible's window
> >  c) special-case input only windows somehow (either in all code
> >     using window->colormap, or maybe gdk_drawable_get_colormap()
> >     would return the default cmap for input-only windows - putting
> >     the special case in only one spot)
> 
> Another possibility (perhaps considered unthinkable by GTK savants):
> 
>     d) Allow attaching a style to a window with a NULL colormap. Change
>        the gtk_style_attach/detach code to keep the style into an
>        appropriate state (need not be really "usable").
> 

That works too. I'm having a hard time coming up with any really good
reason to prefer any of these...

Another thought I just had: I don't know why GtkInvisible bothers to
have an input only window anyhow - the window gets positioned
offscreen. So it could just be a visible window. I guess input only is
mildy more efficient on the server, that's all I can think of.

Havoc





[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]