Re: Glib logging disable patch

[Alexander Larsson <alla lysator liu se>]

On Fri, 22 Dec 2000, Federico Mena Quintero wrote:

> Alexander Larsson <alla lysator liu se> writes:
> 
> > This patch is critical in compiling a slimmed down glib.
> > Is this ok to check in?
> >
> > +
> > +#if defined(G_DISABLE_LOGGING)
> > +
> >  #if defined (__STDC_VERSION__) && __STDC_VERSION__ >= 199901L
> > +#define g_error(...)    (void)0
> > +#define g_message(...)  (void)0
> > +#define g_critical(...) (void)0
> > +#define g_warning(...)  (void)0
> > +#elif __GNUC__ > 2 || (__GNUC__ == 2 && __GNUC_MINOR__ >= 4)
> > +#define g_error(format...) (void)0
> > +#define g_message(format...) (void)0
> > +#define g_critical(format...) (void)0
> > +#define g_warning(format...) (void)0
> > +#else   /* !__GNUC__ */
> > +static void
> > +g_error (const gchar *format, ...)
> > +{
> > +}
> 
> Shouldn't g_error() at least abort()?

 Yes, probably.

/ Alex