Re: removal of getpwuid from gtk/gtkfilesel.c



Hi,

> > couldn't we remove the use of getpwuid from gtk/gtkfilesel.c to avoid
> > duplicating the MT safety mess from glib/gutils.c. getpwuid is only 
> > used here to find the home dir, which is also done in gutils.c.
> > Atached is a patch to do that.
> 
> Hmmm, don't the calls to getpwnam just underneath (in the
> ~user part) have the the same reentrancy concerns as
> getpwuid?

Yes, sure, but the once is better, that the mess twice. Despite that it is
semantically better, if all progs using glib, behave the same way in
determining the users homedir. That is best done such.

Bye,
Sebastian

-- 
Sebastian Wilhelmi                   |            här ovanför alla molnen
mailto:wilhelmi@ira.uka.de           |      är himmlen så förunerligt blå
http://goethe.ira.uka.de/~wilhelmi   |



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]