g_log_domain_gthread problem



        You might have seen this by the time you read my email, but I
wasn't sure of the "correct" solution, so I wasn't going to go ahead
and commit.
        gthread.c includes glib.h *before* declaring 
g_log_domain_gthread, so G_LOG_DOMAIN substitutions in glib.h don't
compile.  A simple reorder fixes this, but I wasn't sure if that was the
'correct' answer.  So I email.  Here is the patch:


Index: gthread.c
===================================================================
RCS file: /cvs/gnome/glib/gthread/gthread.c,v
retrieving revision 1.3
diff -u -r1.3 gthread.c
--- gthread.c   1998/12/16 05:38:34     1.3
+++ gthread.c   1998/12/16 16:00:44
@@ -28,9 +28,10 @@
 #include <config.h>
 #endif
 
+static const char *g_log_domain_gthread = "GThread";
+
 #include <glib.h>
 
-static const char *g_log_domain_gthread = "GThread";
 static gboolean thread_system_already_initialized = FALSE;
 
 #include G_THREAD_SOURCE



-- 

"Come on home girl, gonna make you smile.
 Cast my spell of love on you; a woman from a child.
 But try to understand, try to understand,
 Try, try, try to understand:
 I'm a magic man."

                                  jlbec@ocala.cs.miami.edu
                                  gr311@cleveland.freenet.edu
                                  http://ocala.cs.miami.edu/~jlbec



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]