Re: GTK+-2.3.4 released [unstable]

[Tomasz Kłoczko <kloczek rudy mif pg gda pl>]

On Wed, 25 Feb 2004, Owen Taylor wrote:
[..]
> Looks like we're missing a requirement on glib-2.3.3, upgrade and make
> sure GTK+ is finding it and you should be fine. (G_DEFINE_TYPE changed
> slightly between 2.3.2 and 2.3.3)

Yes. This was compiled on glib 2.3.2.
Why (the hel) gtk+ autoconf script have incorrect checking enviromet ? ;)

<disclaimer>I have RW access</dislaimer>
Is it not will be good commit to gtk+ ?

Index: configure.in
===================================================================
RCS file: /cvs/gnome/gtk+/configure.in,v
retrieving revision 1.361
diff -u -r1.361 configure.in
--- configure.in        25 Feb 2004 00:43:21 -0000      1.361
+++ configure.in        25 Feb 2004 16:33:40 -0000
@@ -29,7 +29,7 @@
 m4_define([gtk_binary_version], [2.2.0])
 
 # required versions of other packages
-m4_define([glib_required_version], [2.3.2])
+m4_define([glib_required_version], [2.3.3])
 m4_define([pango_required_version], [1.2.0])
 m4_define([atk_required_version], [1.0.1])

or even better (because this is not first time)

Index: configure.in
===================================================================
RCS file: /cvs/gnome/gtk+/configure.in,v
retrieving revision 1.361
diff -u -r1.361 configure.in
--- configure.in        25 Feb 2004 00:43:21 -0000      1.361
+++ configure.in        25 Feb 2004 16:35:54 -0000
@@ -29,7 +29,7 @@
 m4_define([gtk_binary_version], [2.2.0])
 
 # required versions of other packages
-m4_define([glib_required_version], [2.3.2])
+m4_define([glib_required_version],[$gtk_major_version.$gtk_minor_version.$gtk_micro_version])
 m4_define([pango_required_version], [1.2.0])
 m4_define([atk_required_version], [1.0.1])

kloczek
-- 
-----------------------------------------------------------
*Ludzie nie majï problemïw, tylko sobie sami je stwarzajï*
-----------------------------------------------------------
Tomasz Kïoczko, sys adm @zie.pg.gda.pl|*e-mail: kloczek rudy mif pg gda pl*