Re: [gthumb-list] Auto-orientation issue

[Nicolas <progweb free fr>]

Le vendredi 23 juillet 2010 à 23:46 +0200, Paolo Bacchilega a écrit :
> Il 23/07/2010 23:31, Nicolas ha scritto:
> > Le jeudi 22 juillet 2010 à 23:09 +0200, Paolo Bacchilega a écrit :
> > > the metadata is read in gth-import-task.c:302 with the function
> > > exiv2_read_metadata_from_buffer, you should check if this function reads
> > > the metadata correctly.
> >
> > Thanks,
> >
> > It's a bad alert.
> >
> > The exiv2 extension wasn't built !
> >
> > But, I have an other issue in attachment :(
> >
> > You can find the backtrace.
> >
> > Regards,
> >
> > Nicolas
>
> this should be fixed in current master
>
> - Paolo

I test.

I have prepared a patch to avoid the crash...

diff --git a/gthumb/gth-main.c b/gthumb/gth-main.c
index c1d75d7..0fc6e3a 100644
--- a/gthumb/gth-main.c
+++ b/gthumb/gth-main.c
@@ -564,6 +564,9 @@ gth_main_get_metadata_category (const char *id)
 {
        int i;
 
+       if (id == NULL)
+               return NULL;
+
        for (i = 0; i < Main->priv->metadata_category->len; i++) {
                GthMetadataCategory *category;
 
@@ -581,6 +584,9 @@ gth_main_get_metadata_info (const char *id)
 {
        int i;
 
+       if (id == NULL)
+               return NULL;
+
        for (i = 0; i < Main->priv->metadata_info->len; i++) {
                GthMetadataInfo *info;
 


Regards,

Nicolas