Re: Odd thing in lua-library

[Victor Toso <lists victortoso com>]

Hi George,

On Wed, Aug 05, 2015 at 02:39:34AM +0300, George Sedov wrote:
> Hi guys,
>
> Since Toso said that I should use the maillist when I want a quick
> reaction, I'm writing here.

Yes, I do prefer mailing list then not having anyone to reply on IRC ;)

> Please, look at this line:
>
> https://git.gnome.org/browse/grilo-plugins/tree/src/lua-factory/grl-lua
> -library.c#n809
>
> Is there supposed to be "3"? I don't see "2" used anywhere, but maybe
> I'm missing something.

<snip>
if (g_strcmp0 (option, "range-filter") == 0) {
    GValue *min = NULL;
    GValue *max = NULL;
    GrlKeyID key;
    const gchar *key_name = NULL;
    GrlRegistry *registry = grl_registry_get_default ();

    luaL_argcheck (L, lua_isstring (L, 3), 3, "expecting key name");
    key_name = lua_tostring (L, 3);

    key = grl_registry_lookup_metadata_key (registry, key_name);
</snip>

I don't think you are missing anything, it is a bug. The second
parameter of range-filter should be the key-name. git blame shows that
this is there since lua-factory was introduced.

Patch? :D

cheers,
 toso