Patch reviews, change API and resolve API



Heya,

1) There are a good bunch of changes still to review for Grilo, changes
which I mainly made for Totem in GNOME 3.12:
https://bugzilla.gnome.org/page.cgi?id=patchreport.html&product=grilo&patch-status=none

The only blocking patch for Totem is:
https://bugzilla.gnome.org/show_bug.cgi?id=722358

The others I can live with them being only in my local tree... for
now! :)

Thanks for the reviews so far Juan

2) I'd also like some guidance on the last patch to:
https://bugzilla.gnome.org/show_bug.cgi?id=722629

I don't quite understand the API of:
grl_source_notify_change()
and the "content-changed" signal.

For example, I'd like to signal that a particular media (say, a DVD
image) in the optical media source got removed. It seems that I can't
just pass the GrlMedia representing the DVD image to the function. I'd
need to pass %NULL to represent the root of the source, and then browse
again?

Should grl_source_notify_change() warn if the GrlMedia is neither %NULL
nor a GrlMediaBox?

3) Finally, I wanted to be able to add thumbnails to items retrieved
from the Tracker plugin. It looks like I need to use the local-metadata
plugin to do that, but, in the future, I want to use the tmdb plugin to
look up more data.

Is it possible to do lookups only using local-metadata but not tmdb for
some calls, but use all available sources for others?

Cheers



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]