Re: [PATCH] core: Use full path to load plugin information

[Guillaume Emont <guijemont igalia com>]

Woops.

Sorry this patch got unnoticed for so long.
I assume this is a patch against 0.1.x, which is not an issue, but
please try to specify it when submitting a patch (we have two "active"
branches these days: master aka "future 0.2" and 0.1.x).

As I am not personally familiar with this area of the code, I would be
happy if you can tell me why you are doing this change: did you have
conditions where you had an issue with the code not attempting to load
the plugin using the full path here? Would help me much to test the
patch, (which otherwise looks sensible to me), and eventually merge it.
Thanks.

I am also trying to understand whether the original author deliberately
only used the filename or if the full path was what was originally
meant. Git blame tells me the author is Juan: Juan, do you remember?

Cheers,

Guij

On 08/10/2011 09:09, Jens Georg wrote:
> ---
>  src/grl-plugin-registry.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/src/grl-plugin-registry.c b/src/grl-plugin-registry.c
> index 628d6b3..f1f6548 100644
> --- a/src/grl-plugin-registry.c
> +++ b/src/grl-plugin-registry.c
> @@ -675,7 +675,7 @@ grl_plugin_registry_load (GrlPluginRegistry *registry,
>                                                   NULL);
>      plugin_info = grl_plugin_registry_load_plugin_info (registry,
>                                                          plugin->plugin_id,
> -                                                        plugin_info_filename);
> +                                                        plugin_info_fullpathname);
>      if (!plugin_info) {
>        GRL_WARNING ("Plugin '%s' does not have XML information file '%s'",
>                     plugin->plugin_id,