Re: [PATCH 1/1] grl-net: Use libsoup cache



On Tue, Mar 15, 2011 at 01:27:14PM +0100, Juan A. Suarez Romero wrote:

nitpick: I'm not big fan of function predefining. With out them, the code flow is more
natural in my opinion.

>  
> +#ifdef LIBSOUP_USE_UNSTABLE_REQUEST_API
> +static void cache_down (GrlNetWc *self);
> +static void cache_up (GrlNetWc *self);
> +static SoupCache *get_cache();
> +#endif

And I guess we could get rid of these predefinitions, specially the get_cache(),
which is only used by cache_down() and cache_up().

vmjl


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]